Reporting A Bug of Hotkey Configure - FamiTracker

# FamiTracker

FamiTracker Support Forums

Skip to content

## Reporting A Bug of Hotkey Configure

Please post about bugs here.
Forum rules
When making a bug report, please try to be as specific as possible. Include information on how to reproduce the bug and an example file if possible.
If the application crashed, please include the generated memory dump file as well.
Post Reply

- Print view

4 posts • Page 1 of 1

womo
  Posts: 15
  Joined: Thu May 14, 2015 3:43 am
  Location: China

### Reporting A Bug of Hotkey Configure

- Quote

Post by womo » Wed May 27, 2015 12:39 pm

When one of the hotkey list in the configure window is selected, you can use keyboard up and down to navigate the cursor to the next/prev item, but the text in "Keys" input area doesn't change with the cursor, and even if you press Tab key to switch to it, it still changes the hotkey of the last item which was clicked by mouse.
Last edited by womo on Fri May 29, 2015 12:50 pm, edited 1 time in total.
Top

HertzDevil
  Posts: 475
  Joined: Thu Apr 23, 2015 7:39 pm
  Location: Hong Kong SAR
  Contact:
  Contact HertzDevil
  Website Facebook Twitter Skype
  YouTube

### Re: Reporting A Bug of Hotkey Configure

- Quote

Post by HertzDevil » Wed May 27, 2015 1:08 pm

Send both NM_CLICK and LVN_ITEMCHANGED to CConfigShortcuts::OnNMClickShortcuts.
refactoring 0cc-famitracker
Top

womo
  Posts: 15
  Joined: Thu May 14, 2015 3:43 am
  Location: China

### Re: Reporting A Bug of Hotkey Configure

- Quote

Post by womo » Wed May 27, 2015 2:02 pm

> HertzDevil wrote:Send both NM_CLICK and LVN_ITEMCHANGED to CConfigShortcuts::OnNMClickShortcuts.

Yeah it works, thank you!
There's no need to bind NM_CLICK if binded LVN_ITEMCHANGED, because clicking triggers the selected item change. However the CConfigShortcuts::OnNMClickShortcuts(HMHDR, LRESULT) requires some edit to make it perfect.

Code: Select all

`void CConfigShortcuts::OnNMClickShortcuts(NMHDR *pNMHDR, LRESULT *pResult)
{
// If you do it in this way, the text would only change when the mouse button is released, and the
// key text would incorrectly show the last item you pressed.
// CListCtrl *pListView = static_cast<CListCtrl*>(GetDlgItem(IDC_SHORTCUTS));
// m_iSelectedItem = pListView->GetSelectionMark();
// This is the proper way, the text would change immediately when you pressed mouse button.
m_iSelectedItem = reinterpret_cast<LPNMLISTVIEW>(pNMHDR)->iItem;
CString KeyString = AssembleKeyString(m_iMods[m_iSelectedItem], m_iKeys[m_iSelectedItem]);
SetDlgItemText(IDC_KEY, KeyString);
*pResult = 0;
}`
I hope jsr fix it to the release of 0.5.0.
Top

jsr
  Site Admin
  Posts: 112
  Joined: Tue Jan 06, 2015 1:25 pm

### Re: Reporting A Bug of Hotkey Configure

- Quote

Post by jsr » Thu May 28, 2015 10:35 pm

> womo wrote:I hope jsr fix it to the release of 0.5.0.

I'll add this, thanks.
Famitracker developer
Top

Display posts from previous:
Sort by

Post Reply

- Print view

4 posts • Page 1 of 1

Return to “Bug Reports”

Jump to

- Rules
- Wiki
- FamiTracker
- General Talk
- Bug Reports
- Feature Requests
- Source and development
- Music
- Original Music
- Cover Music
- Other
- Site Issues & Suggestions